Skip to content

Fix elastic agent core spec again#7816

Closed
pchila wants to merge 2 commits intoelastic:mainfrom
pchila:fix-elastic-agent-core-spec-again
Closed

Fix elastic agent core spec again#7816
pchila wants to merge 2 commits intoelastic:mainfrom
pchila:fix-elastic-agent-core-spec-again

Conversation

@pchila
Copy link
Member

@pchila pchila commented Apr 10, 2025

What does this PR do?

Revert changes introduced with #7805 (there's a side effect as the filenames for fips artifacts are changed to elastic-agent-fips-core due to the usage of qualifier.
This breaks also elastic-agent-core uploads in elastic-agent-binary-dra pipeline: https://buildkite.com/elastic/elastic-agent-binary-dra/builds/3060
Fix rootDir of the elastic-agent-core artifacts in packages.yaml

Why is it important?

To have consistent naming of artifacts

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila requested a review from a team as a code owner April 10, 2025 16:32
@pchila pchila self-assigned this Apr 10, 2025
@pchila pchila requested review from marc-gr and pkoutsovasilis and removed request for blakerouse and michalpristas April 10, 2025 16:33
@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pchila pchila added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels Apr 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pchila
Copy link
Member Author

pchila commented Apr 10, 2025

Successful elastic-agent-binary-dra dry-run https://buildkite.com/elastic/elastic-agent-binary-dra/builds/3062

@pchila pchila removed the request for review from marc-gr April 10, 2025 17:02
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pchila
Copy link
Member Author

pchila commented Apr 10, 2025

Closed in favor of #7818

@pchila pchila closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip bug Something isn't working skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants